Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WSTEAM1-1408: Populates 'x2' ATI value with 'lite' for .lite pages #12178

Merged
merged 6 commits into from
Nov 15, 2024

Conversation

Isabella-Mitchell
Copy link
Contributor

@Isabella-Mitchell Isabella-Mitchell commented Nov 15, 2024

Resolves JIRA [WSTEAM1-1408]

Overall changes

Populates 'x2' ATI value for Piano with 'lite' for .lite pages

Code changes

  • Sets the Platform value to 'lite' for .lite pages. (Follows pattern already put in place by .app)
  • Sets AppType value to 'lite' for .lite pages
  • Refactors integrationTest to make the platform more explicit

Testing

  1. Visit any .lite page on latest. E.g. https://www.bbc.com/afrique/articles/cn01kyjj230o.lite
  2. Visit the same page locally E.g. http://localhost:7080/afrique/articles/cn01kyjj230o.lite?renderer_env=live
  3. For each, go to the Network Tab and filter by 'Fetch/XHR'
  4. Compare the analytics request. All values should match apart from 'x2:'. Locally this should be [lite] and not [responsive]

Helpful Links

Add Links to useful resources related to this PR if applicable.

Coding Standards

Repository use guidelines

@Isabella-Mitchell Isabella-Mitchell marked this pull request as ready for review November 15, 2024 11:04
@Isabella-Mitchell Isabella-Mitchell changed the title Wsteam1 1408 add lite platforms type WSTEAM1-1408: Populates 'x2' ATI value for Piano with 'lite' for .lite pages Nov 15, 2024
@Isabella-Mitchell Isabella-Mitchell changed the title WSTEAM1-1408: Populates 'x2' ATI value for Piano with 'lite' for .lite pages WSTEAM1-1408: Populates 'x2' ATI value with 'lite' for .lite pages Nov 15, 2024
@Isabella-Mitchell Isabella-Mitchell merged commit 2a7f864 into latest Nov 15, 2024
11 checks passed
@Isabella-Mitchell Isabella-Mitchell deleted the WSTEAM1-1408-add-lite-platforms-type branch November 15, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants